Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend IAM datastore with lower case values for faster access #430

Merged
merged 1 commit into from
Aug 29, 2023
Merged

extend IAM datastore with lower case values for faster access #430

merged 1 commit into from
Aug 29, 2023

Conversation

gruebel
Copy link
Collaborator

@gruebel gruebel commented Aug 28, 2023 •
edited
Loading

What does this PR do?

  • extended the IAM datastore with lower case values maps for faster access
  • added a schema version indication to better handle future upgrades
  • created v1 and v2 versions for multiple functions, no breaking change

Speed comparison pytest test suite on Python 3.7 took before ~30sec and now ~20sec 🚀

What gif best describes this PR or how it makes you feel?

Completion checklist

@gruebel gruebel added the enhancement New feature or request label Aug 28, 2023
@kmcquade
Copy link
Collaborator

Brilliant idea!

@gruebel gruebel merged commit a06d95c into salesforce:master Aug 29, 2023
6 checks passed
@gruebel gruebel deleted the extend-iam-datastore branch August 29, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcquade kmcquade kmcquade approved these changes

Assignees
No one assigned
Labels
cla:signed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruebel @kmcquade