Refactor code smells #255
Open
Refactor code smells #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et HTMLAttributes type as HTMLDivElement
….assign' return as BoxProps
…' as type of Component
….assign' return as ItemProps
…renderItem methods by changing descriptor argument type to WorkFlowDescriptor
…r attribute by set type as HTMLDivElement or null
…derItem method of FlowItens class
…erItems method to render main method
…hod renderItems method to outside of WorkFlowItems
…hod getComponentByType to outside of WorkFlowGlobalParameters class
…structuring props in workflow configurations
…meProps class and use in render method in workflow sider container
… ads, docs button, github button, question button, menu, editor change, title and title bar components in layout folder
… url modal label component and use him in url modal
…structuring props in style.js imagemap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes that were mentioned in this issue [ #254 ].