Tail call stack flattening #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does create some O0 performance penalties, but this can be reduced by making a cache type, using registers where it doesn't write the value straight to the address, instead writing to a local reg first, and only storing to disk when it needs to be composed into a struct or for a value loan
AjaniBilby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the stack issue created by pr #8, where tail calls now aren't fully applicable due to the stack growing with each call.
Implement the
return_callstatement so that it does a safety check that none of the values parsed to the call are allocated in the local stack (if they are, throw a compilation error). Once that is done, call the function without shifting the stack forward and use thereturn_callwasm instruction.