Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic String Constants #13

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Basic String Constants #13

merged 6 commits into from
Apr 18, 2024

Conversation

AjaniBilby
Copy link
Member

This is just a very primative implementation of string constants and likely to change.

Basically we just want to be able to have a string constant for responding in the HTTP Ping Server milestone, so basically it will take the string data, store the UTF-8 encoding in the linear memory on init, and result in a iovec being placed on the stack which refers to that section of data.

@AjaniBilby AjaniBilby added the enhancement New feature or request label Apr 10, 2024
@AjaniBilby AjaniBilby added this to the HTTP ping server milestone Apr 10, 2024
@AjaniBilby AjaniBilby self-assigned this Apr 10, 2024
This was referenced Apr 10, 2024
@AjaniBilby AjaniBilby removed this from the HTTP ping server milestone Apr 10, 2024
@AjaniBilby
Copy link
Member Author

Constant strings currently resolve to an i32 which is just a pointer to a global shared iovec.
In the future they should return the iovec itself.
But for now it's just an int to get the benchmarks rolling

@AjaniBilby AjaniBilby marked this pull request as ready for review April 18, 2024 03:49
@AjaniBilby AjaniBilby merged commit d076b9b into main Apr 18, 2024
1 check passed
@AjaniBilby AjaniBilby deleted the primative-string-constants branch April 18, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant