Make a test PR 2 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a test PR 2
Test Results8 tests 7 ✅ 7s ⏱️ For more details on these failures, see this check. Results for commit 25f8338. |
salinecitrine
pushed a commit
that referenced
this pull request
Aug 9, 2024
…nit shaders (beyond-all-reason#3536) * Initial commit of testing Construction shader * Use one noise channel to offset the steps * better mixing * grid effect * Add selectedness to UnitBufferUniforms entry #6 * different construction patterns * Enable on-the-fly editing of CUS GL4 shaders when autoReload.enabled is true * Better autoreload conf for cus gl4 * move selection highlights into cus gl4 fully * SelectedUnitGL4 manages mouseover highlight too! * Mark usage of the HighLightUnitGL4 API as deprecated * rewrite construction effect * also clear normals from depth buffer * reorder depth buffer visualizer rendering to prevent post-effects from touching them * Move logic that updates buildprogress unit buffer uniform from healthbars gl4 to cus gl4 * Add selectionHighlight and mouseoverHighlight config bools to selected units gl4 * timeInfo.z = (timeInfo.x + timeInfo.w) / 30 * fix initial damagedness of built things * less harsh shading * Unit heights are taken from model.maxy instead of GetUnitHeight * demonstrate alpha modulation in the forward pass, pull back noise near completion * document * Put cloak effect into CUS as well. * Make LUPS GL4 Orbs grow into place instead of popping * Slower cloak noise effect * tune levels * quicker orb spinup * Set mouseover and selection highlights in options * Remove deprecated Highlight Unit API consumers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a test PR 2
Work done
Test steps