Add guzzle sender that extends Saloon's default sender (linked to PR in saloon itself) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sammyjo20
approved these changes
May 14, 2024
There was a problem hiding this comment.
Thank you @gdebrauwer I like this addition, I'm a little worried this might start causing issues for people. Do you forsee any issues with introducing this in the next minor update, like issues with closing connections with Octane? etc.
|
I don't think this will cause issues on Octane as we are not creating a singleton. |
|
Whats the status on this? @Sammyjo20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
laravel-http-senderpackage is being sunset, but I still want requests/responses to be logged in Telescope. Then I discovered this is possible with the following package: https://github.com/huzaifaarain/telescope-guzzle-watcher/tree/mainThe problem is that this package only works if the guzzle client is created using the service container. That is currently not the case.
This PR and PR saloonphp/saloon#403 make that possible with minimal changes.