Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature | Add Generics For Query / LazyQuery #17

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Feature | Add Generics For Query / LazyQuery #17

merged 3 commits into from
Nov 12, 2023

Conversation

Sammyjo20
Copy link
Member

@Sammyjo20 Sammyjo20 commented Nov 12, 2023 •
edited
Loading

This PR introduces generics for the Query and LazyQuery class which help IDE auto-completion when using any of the reader methods. Previously if you wrote something like this:

$reader->element('breakfast_menu.food.0')->sole();

You wouldn't be able to see any of the methods from the Element class. Now you can.

Screenshot 2023-11-12 at 22 48 10

Sammyjo20
Sammyjo20 commented Nov 12, 2023
View reviewed changes
Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 changed the title Fix | Use veewee/xml ^2.11.2 Feature | Add Generics For Query / LazyQuery Nov 12, 2023
Sammyjo20
Sammyjo20 commented Nov 12, 2023
View reviewed changes
Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 merged commit f5ea79c into v1 Nov 12, 2023
10 checks passed
@Sammyjo20 Sammyjo20 deleted the fix/use-veewee-xml-2.11.2 branch November 12, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sammyjo20