Upgrade | PHP 8.3 & veewee/xml v3.1
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Little nudge.... (please). 🤠 |
|
Hey @fredbradley I'm really really sorry for the delay on this PR. I'll get it merged this week! |
Sammyjo20
approved these changes
Aug 3, 2024
Sammyjo20
changed the title
veewe/xmlveewee/xml v3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Sammyjo20 I'm a big fan of Saloon and this XML Wrangler. 🤠
I'm going through the process of updating my apps to 8.3, and when I noticed this didn't pass tests on 8.3, I delved a bit deeper. I have upgraded
veeweeto use the new version that supports 8.3 and amended your code to cope with their breaking change.All your tests pass. Lines 335-337 in XmlReader.php are a bit messy on the
elsestatement, but I couldn't easily find a cleaner way to do it.(Documentation of @veewee's breaking change is here: https://github.com/veewee/xml/releases/tag/3.0.0)