Skip to content

Remove dependency on /usr/local/munki/munkilib for munkiinfo.py #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dependency on /usr/local/munki/munkilib for munkiinfo.py #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions server/plugins/munkiinfo/scripts/munkiinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,16 @@
import sys

import sal
sys.path.append('/usr/local/munki')
from munkilib import munkicommon

from Foundation import CFPreferencesCopyAppValue, NSDate


def munkiPref(pref_name):
pref_value = CFPreferencesCopyAppValue(pref_name, "ManagedInstalls")
if isinstance(pref_value, NSDate):
# convert NSDate/CFDates to strings
pref_value = str(pref_value)
return pref_value


PREFS_TO_GET = (
Expand Down Expand Up @@ -60,7 +68,7 @@ def main():
# Manual check: skipping MunkiInfo Plugin
exit(0)

data = {pref: str(munkicommon.pref(pref)) for pref in PREFS_TO_GET}
data = {pref: str(munkiPref(pref)) for pref in PREFS_TO_GET}
sal.add_plugin_results('MunkiInfo', data)


Expand Down