-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add release workflow #658
base: master
Are you sure you want to change the base?
add release workflow #658
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
Thanks; this is great. Would you mind extending the README with a Contributing section that explains how to make a release? |
Done. |
Ooh, this is awesome, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. It won't work as is though because publishing salsa requires publishing both salsa and salsa-macros. Also, the two step process (edit version(s), issue git tag) is maybe a bit more complex than I'd like.
My suggestion: let's create a cargo xtask like cargo publish-salsa
and then modify it so that...
cargo publish-salsa
with no arguments dumps some helpcargo publish-salsa prepare
modifiesCargo.toml
with new version and creates the git tag. It can also check that nothing is dirty in git. We should probably start maintaining release notes but that can wait.cargo publish-salsa from-ci
actually does the work. Ideally it should also assert that the tag has been pushed to main so we avoid publishing things that don't exist in main. But that can be a FIXME.
Are they always published in same versions? You can also check |
They are always in lockstep. Also I think there are now 3 crates. https://github.com/release-plz/release-plz also looks neat -- probably there exist utilities for this by now. |
This PR adds a GitHub Actions workflow for publishing crate to crates.io.
Once merged this PR, remember to :
CARGO_REGISTRY_TOKEN
and paste the token into there.To publish a new version to crates.io, just update the
version
field of Cargo.toml and create a corresponding Git tag.Hope it helps. I'm looking forward to new versions of Salsa.