Adding conditional processing of swift auth parameters #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes should patch an issue observed in Ocata when Swift is set as Glance backend with *references* method of auth sections addressing. While `glance-api.conf` template is set to check for swift auth parameters definition, `glance-glare.conf` is not which makes salt-formula-glance fail during execution.
epcim
requested changes
May 22, 2018
| @@ -1862,8 +1872,8 @@ swift_store_key = {{ server.storage.swift.store.key }} | |||
| # | |||
| # (string value) | |||
| #swift_store_config_file = <None> | |||
| {% if server.storage.swift.store.config_file is defined %} | |||
| swift_store_config_file = {{ server.storage.swift.store.config_file }} | |||
| {% if server.storage.swift.store.references is defined %} | |||
There was a problem hiding this comment.
can you touch to keep backward compatible, so sth like
if server.storage.swift.store.references is defined
< new code >
else
end
There was a problem hiding this comment.
Hi @epcim, change is just reflecting same code block as in glance-api.conf https://github.com/salt-formulas/salt-formula-glance/blame/master/glance/files/ocata/glance-api.conf.Debian#L3221 commit 3a86781 this change was not done in glance-glare.conf which is now causing problems.
I think glance-api.conf and glance-glare.conf should have same code logic.
What do you think?
Thanks.
There was a problem hiding this comment.
@LotharKAtt @Martin819 Hi guys, could anyone of you comment or even merge this PR? Thanks a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should patch an issue observed in Ocata when Swift
is set as Glance backend with references method of auth sections
addressing. While
glance-api.conftemplate is set to check forswift auth parameters definition,
glance-glare.confis not whichmakes salt-formula-glance fail in execution.