*: Add repo update steps #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the first sample of the main.yaml workflow
This commit adds the ability to specify a namespace for the service
account used to authenticate to Vault. This is useful when you want to
use a service account in a different namespace than the one the secret
(vaultStaticSecret, vaultDynamicSecret) is located. This change is
backwards compatible, so if no namespace is specified, the service
account will be looked up in the same namespace as the secret.
Example: Here the service account that will be used to authenticate to
Vault is the service account `default` that it is in the namespace
"vault-secrets-operator-system".
```yaml
apiVersion: secrets.hashicorp.com/v1beta1
kind: VaultAuth
metadata:
name: static-auth
namespace: app
spec:
vaultConnectionRef: vault-connection
allowedNamespaces:
- "*"
method: kubernetes
mount: demo-auth-mount
kubernetes:
role: role1
serviceAccount: vault-secrets-operator-system/default
```
Closes hashicorp#336
|
We can include the commit sha or the revision tag to the backup branch. |
glerchundi
requested changes
Jan 11, 2024
inigohu
force-pushed
the
feature/add-repo-update
branch
from
e2d3ee0 to
125d57a
Compare
Updated |
glerchundi
reviewed
Jan 12, 2024
To avoid future problems with the repo, we need to add the steps to update the repo with the new changes from the upstream repo.
inigohu
force-pushed
the
feature/add-repo-update
branch
from
125d57a to
403fc35
Compare
|
➜ vault-secrets-operator git:(main) git tag -d v0.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid future problems with the repo, we need to add the steps to update the repo with the new changes from the upstream repo.