Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] add debian buster #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arthurzenika
Copy link
Contributor

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@myii
Copy link
Member

myii commented Dec 13, 2019

@arthurlogilab We're using pre-salted images for testing across 60+ formulas now. They're a much faster and a more efficient use of our Travis concurrency (only 3 jobs across the whole org). So please take the definitions from the template-formula, to use those instead.

Or perhaps we can implement semantic-release for this formula. The process automatically configures all of the pre-salted images. What do you think?

@arthurzenika
Copy link
Contributor Author

@myii semantic-release for this formula would be great !

Is there an easy way to take the sane defaults in template-formula, apply them to this formula (or another) and create a merge request ?

@myii
Copy link
Member

myii commented Dec 18, 2019

... semantic-release for this formula would be great !

OK, I'll try to prepare something fairly soon.

Is there an easy way to take the sane defaults in template-formula, apply them to this formula (or another) and create a merge request ?

We've been using the ssf-formula to keep everything synchronised across all of these formulas. An example PR for adding another formula to be managed:

It's proved to be fairly robust (except for the Git scripts which will need to be improved). It may be difficult to get familiar with for other contributors, though. It's quite dense.

@javierbertoli
Copy link
Member

@arthurlogilab, I think I fixed all the issues with this PR (running local tests now), Are you OK if I push here?

@arthurzenika
Copy link
Contributor Author

@javierbertoli sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants