Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clean): fix syntax error with use_upstream repo #285

Merged
merged 8 commits into from
May 20, 2021
Merged

fix(clean): fix syntax error with use_upstream repo #285

merged 8 commits into from
May 20, 2021

Commits on May 19, 2021

  1. fix(clean): fix syntax error with use_upstream repo 

    With use_upstream: repo, several errors occur:
- An invalid state id is used to require the repo state
- An incorrect path to include the repo state is used
- A dictionary with conifguration is incorrectly passed to the onlyif statement,
  which is already checked by the if-statement around it.
    @danny-smit
    Danny Smit authored and danny-smit committed May 19, 2021
    Configuration menu
    Copy the full SHA
    428dccd View commit details
    Browse the repository at this point in the history

  2. fix(clean): fix clean of repo for the RedHat family 

    The clean failed due to a mismatch of the name of the repo that was installed.
    @danny-smit
    Danny Smit authored and danny-smit committed May 19, 2021
    Configuration menu
    Copy the full SHA
    4730a72 View commit details
    Browse the repository at this point in the history

  3. fix(test): add missing tests to verify installation from repo

    @danny-smit
    Danny Smit authored and danny-smit committed May 19, 2021
    Configuration menu
    Copy the full SHA
    5a62de9 View commit details
    Browse the repository at this point in the history

  4. fix(clean): make repo install and clean states consistent

    @danny-smit
    danny-smit committed May 19, 2021
    Configuration menu
    Copy the full SHA
    af16bb7 View commit details
    Browse the repository at this point in the history

  5. fix(clean): update condition that enables the repo

    @danny-smit
    danny-smit committed May 19, 2021
    Configuration menu
    Copy the full SHA
    1f5190b View commit details
    Browse the repository at this point in the history

  6. fix(clean): remove invalid 'onlyif' statement from repo.clean 

    A dictionary is passed to the salt 'onlyif' condition. This is invalid syntax
and the condition is already checked by in the jinja around it.
    @danny-smit
    danny-smit committed May 19, 2021
    Configuration menu
    Copy the full SHA
    b3c56cb View commit details
    Browse the repository at this point in the history

  7. fix(clean): fix syntax error in networks.clean state file

    @danny-smit
    danny-smit committed May 19, 2021
    Configuration menu
    Copy the full SHA
    53db7ad View commit details
    Browse the repository at this point in the history

  8. fix(clean): update enable_repo condition to be more robust

    @danny-smit
    danny-smit committed May 19, 2021
    Configuration menu
    Copy the full SHA
    a7f382f View commit details
    Browse the repository at this point in the history