Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve binary releases from github instead of bintray #290

Merged
merged 2 commits into from
May 19, 2021

Conversation

danny-smit
Copy link
Collaborator

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#281

Describe the changes you're proposing

Replace URLs to bintray.com with URLs to github.com to retrieve binary releases.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@danny-smit
Copy link
Collaborator Author

There is a chicken and egg problem with the tests. The tests for this pull request were failing due to the issue fixed with pull request #288. The tests of pull request #288 were failing due to the problems fixed by this pull request.

Therefore I've pulled in the commit made by @Lucianovici to see if the tests succeed with the fixes of both of the pull requests. I can remove the commit again if it is cleaner to merge both pull requests separately.

@Lucianovici
Copy link

Please also check saltstack-formulas/postgres-formula#311 (review)
Root cause is saltstack/salt#60188
Maybe there is no need to change all salt formulas, let's see how Saltstack team handles this.

@danny-smit
Copy link
Collaborator Author

danny-smit commented May 19, 2021

Thanks for pointing out the other issues. I agree, it seems better to wait for a response from Salt devs before including the fix for the 'imports'.

I'll remove that commit from this pull request again, since we already have #288 for that.

For the record, the tests succeeded with the commit from #288:

All checks have passed
20 successful checks

Copy link
Member

@noelmcloughlin noelmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @danny-smit

@myii myii merged commit 2fd5157 into saltstack-formulas:master May 19, 2021
@saltstack-formulas-travis

🎉 This PR is included in version 2.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii
Copy link
Member

myii commented May 19, 2021

For the record, the tests succeeded with the commit from #288:

All checks have passed
20 successful checks

Thanks @danny-smit, merging this based on that outcome. With the actual testing being here in GitHub Actions, the failures won't prevent semantic-release from running -- which has actually completed as I'm typing this!

Appreciate the review, @noelmcloughlin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants