-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING CHANGE] update for onedir salt package #95
base: master
Are you sure you want to change the base?
Conversation
9904560
to
07a6e46
Compare
1e05928
to
9ebe2bd
Compare
Hello, I work only on debian so I tried to update packages for other OS but I'm not 100% sure that they are the correct ones. |
7285f93
to
49f7d42
Compare
efdedc7
to
c06507f
Compare
I still work on this PR to make the CI run properly. |
7eafeb2
to
205892c
Compare
0c87699
to
8a36a11
Compare
[BREAKING CHANGE] update for onedir salt package
8a36a11
to
03f138b
Compare
I don't understand what's happening with the CI. It's seems that some master images are using salt 3007, 3006.6 or 3006RC1 and some are not with salt onedir. |
The default-debian-10-master-py3 box is outdated, see https://gitlab.com/saltstack-formulas/libvirt-formula/-/jobs/6085940290 :
It refers to this commit, which is more than one year old : The CentOS and Alma boxes are current, though. |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?Yes.
The new version is working only with onedir package. Do not use this version with non onedir salt versions.
Related issues and/or pull requests
#76
Describe the changes you're proposing
Make this formula compatible with onedir salt versions.
Pillar / config required to test the proposed changes
Need onedir Salt version.
Debug log showing how the proposed changes work
N/A
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context