Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] update for onedir salt package #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

didiermfb
Copy link

@didiermfb didiermfb commented Jan 31, 2024

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

Yes.
The new version is working only with onedir package. Do not use this version with non onedir salt versions.

Related issues and/or pull requests

#76

Describe the changes you're proposing

Make this formula compatible with onedir salt versions.

Pillar / config required to test the proposed changes

Need onedir Salt version.

Debug log showing how the proposed changes work

N/A

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@didiermfb didiermfb changed the title BREAKING CHANGE: update for onedir salt package [BREAKING CHANGE] update for onedir salt package Jan 31, 2024
@didiermfb didiermfb force-pushed the feat_onedir_pkg branch 2 times, most recently from 1e05928 to 9ebe2bd Compare January 31, 2024 17:36
@didiermfb
Copy link
Author

Hello, I work only on debian so I tried to update packages for other OS but I'm not 100% sure that they are the correct ones.

@didiermfb didiermfb marked this pull request as ready for review January 31, 2024 17:39
@didiermfb didiermfb requested a review from baby-gnu as a code owner January 31, 2024 17:39
@didiermfb didiermfb force-pushed the feat_onedir_pkg branch 6 times, most recently from 7285f93 to 49f7d42 Compare February 1, 2024 09:48
@didiermfb didiermfb requested a review from a team as a code owner February 1, 2024 09:48
@didiermfb didiermfb force-pushed the feat_onedir_pkg branch 11 times, most recently from efdedc7 to c06507f Compare February 2, 2024 10:08
@didiermfb
Copy link
Author

I still work on this PR to make the CI run properly.

@didiermfb didiermfb force-pushed the feat_onedir_pkg branch 4 times, most recently from 7eafeb2 to 205892c Compare February 2, 2024 14:09
@didiermfb didiermfb force-pushed the feat_onedir_pkg branch 3 times, most recently from 0c87699 to 8a36a11 Compare February 2, 2024 17:12
[BREAKING CHANGE] update for onedir salt package
@didiermfb
Copy link
Author

I don't understand what's happening with the CI. It's seems that some master images are using salt 3007, 3006.6 or 3006RC1 and some are not with salt onedir.
For example AlmaLinux master and CentOS 8 master shouldn't return the error with cp437 encoding as it should use python embedded with salt.
Debian 10 master is using Salt 3006rc1.
I don't know what can I do to resolve this.

@sylvainfaivre
Copy link
Contributor

The default-debian-10-master-py3 box is outdated, see https://gitlab.com/saltstack-formulas/libvirt-formula/-/jobs/6085940290 :

You asked for latest and you have 3006.0+0na.a350c44 installed, sweet!

It refers to this commit, which is more than one year old :
saltstack/salt@a350c44

The CentOS and Alma boxes are current, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants