Skip to content

chore: apply template copier-ssf-ci at version v2.1.0 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeff350
Copy link
Contributor

@jeff350 jeff350 commented Jun 18, 2025

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

chore: apply template copier-ssf-ci at v2.0.1

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@jeff350 jeff350 requested review from a team and sticky-note as code owners June 18, 2025 06:18
@dafyddj
Copy link
Contributor

dafyddj commented Jun 18, 2025

Thanks for the request for feedback.
A few things stand out to me.

  • you weren't to know but Renovate doesn't handle the Copier repo shortcuts such as gh so the template should be initially copied using the full https:// URL - but in this case you can amend it manually in the answers file.
  • the kitchen.vagrant workflows are not functional so to get clean passing tests you can either delete those files or change the on: value to workflow_dispatch so that they don't run automatically.
    In the general case I don't think the Vagrant testing method is viable in CI, not to mention that it is mainly used for the *BSDs which are no longer supported by the core team - so I don't intend to support this method in the template.
    Perhaps after discussion we can get the template to remove those files on migration or use some other semi-automatic method at a later date.
  • lastly the removal of pillars_from _directories - that's fine, but we can have a discussion whether we want to nudge formula authors towards using p_f_d for consistency across formulas. I believe everything that can be done using pillar_from_files can be done using p_f_d in a slightly neater way.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants