Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo, maps): fix keys,paths for onedir,classic #551

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lmf-mx
Copy link

@lmf-mx lmf-mx commented Jul 26, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#548
#545
#539
#550

Describe the changes you're proposing

Updates #548

  • Cover correct key choices depending on version, including edge cases for jammy and RHEL9
  • Sets arch path in repository to match osarch directly, x86_64 is not used in Debian repo definitions
  • Additions are able to be stripped out as repository stops supporting older cases without impact
  • Defaults to onedir for 3005, but allows for pillar override to classic where possible
  • Updates broken links for plist files, sets default to onedir compliant path. Uses pillar, allowing override.
  • Fix commit messages in repositories: fix keys and archs #548 to pass linter

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@lmf-mx lmf-mx requested a review from a team as a code owner July 26, 2023 21:20
@lmf-mx lmf-mx force-pushed the repo_key_fixes branch 2 times, most recently from 21f8851 to d17d13a Compare July 26, 2023 21:32
@gizahNL
Copy link

gizahNL commented Oct 23, 2023

The checksum for debian is incorrectly set. Also some teporary code to set debian to osmajorrelease 11 and oscodename bullseye for onedir is welcome.
Bullseye support isn't offically present, but works in that way.

@lmf-mx
Copy link
Author

lmf-mx commented Feb 23, 2024

The checksum for debian is incorrectly set. Also some teporary code to set debian to osmajorrelease 11 and oscodename bullseye for onedir is welcome. Bullseye support isn't offically present, but works in that way.

@gizahNL Are you asking for an override to ensure onedir on 3005 installs or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants