Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates and fixes #33

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Small updates and fixes #33

merged 3 commits into from
Jan 4, 2024

Conversation

s0undt3ch
Copy link
Contributor

  • Don't set the config value twice for the same marker
  • Update copyright headers
  • Also capture stderr so that no errors are seen on console

@s0undt3ch s0undt3ch requested a review from a team as a code owner January 4, 2024 11:45
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (7665312) 93.09% compared to head (daec41a) 96.85%.
Report is 52 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   93.09%   96.85%   +3.76%     
==========================================
  Files          43       48       +5     
  Lines        1605     2058     +453     
==========================================
+ Hits         1494     1993     +499     
+ Misses        111       65      -46     
Flag Coverage Δ
Linux 98.45% <99.22%> (+3.50%) ⬆️
Py35 ?
Py36 ?
Py37 ?
Py38 ?
Py39 ?
PyTest60 ?
PyTest61 ?
PyTest62 ?
Windows 96.02% <98.47%> (+4.00%) ⬆️
macOS 98.45% <99.22%> (+3.50%) ⬆️
py3.10 96.85% <98.47%> (?)
py3.7 96.83% <98.47%> (?)
py3.8 96.75% <98.47%> (?)
py3.9 96.75% <98.47%> (?)
pytest-7.1.0 98.45% <99.22%> (?)
pytest-7.2.0 98.45% <99.22%> (?)
pytest-7.3.0 96.85% <98.47%> (?)
pytest-7.4.0 96.85% <98.47%> (?)
src 91.00% <95.38%> (+7.95%) ⬆️
tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pytestskipmarkers/__init__.py 100.00% <ø> (ø)
src/pytestskipmarkers/plugin.py 100.00% <100.00%> (ø)
src/pytestskipmarkers/utils/platform.py 100.00% <100.00%> (ø)
src/pytestskipmarkers/utils/ports.py 61.12% <100.00%> (+1.12%) ⬆️
src/pytestskipmarkers/utils/socket.py 100.00% <ø> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
tests/functional/test_destructive_test.py 100.00% <ø> (ø)
tests/functional/test_expensive_test.py 100.00% <100.00%> (ø)
tests/functional/test_requires_network.py 100.00% <100.00%> (ø)
tests/functional/test_skip_if_binaries_missing.py 100.00% <100.00%> (ø)
... and 38 more

@s0undt3ch s0undt3ch merged commit cd52348 into saltstack:main Jan 4, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants