Updated platform support for MacOS using arm64 in function is_aarch64 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for completeness
dwoz
requested changes
Aug 8, 2024
dwoz
approved these changes
Aug 9, 2024
dmurphy18
changed the title
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a MacOS Arm64 system, Python 3 platform.machine() returns
arm64and notaarch64as on Linux Arm64 systems.For example: Ubuntu 20.04.05 arm64 (Pi 4), platform.machine() returns
aarch64Hence need to adjust function
is_aarch64to allow for MacOS Arm64 based system reporting differently.As part of update, updated pre-commit and dropped support for Python 3.7