-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML documentation, test, and readability improvements #63158
Open
rhansen
wants to merge
12
commits into
saltstack:master
Choose a base branch
from
rhansen:yaml-cleanups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 11, 2023
-
yaml: Fix documentation about
datetime
conversionI believe the behavior changed with commit 002aa88 which was first released in Salt v2018.3.0.
Configuration menu - View commit details
-
Copy full SHA for 760b244 - Browse repository at this point
Copy the full SHA 760b244View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7579360 - Browse repository at this point
Copy the full SHA 7579360View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7b41bf - Browse repository at this point
Copy the full SHA e7b41bfView commit details -
yaml: Add integration test for YAML map iteration order
This demonstrates that saltstack#12161 has already been fixed (thanks to Python 3.6 changing `dict` to iterate in insertion order).
Configuration menu - View commit details
-
Copy full SHA for 4b926b0 - Browse repository at this point
Copy the full SHA 4b926b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 252abc0 - Browse repository at this point
Copy the full SHA 252abc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7aa5b2d - Browse repository at this point
Copy the full SHA 7aa5b2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4699911 - Browse repository at this point
Copy the full SHA 4699911View commit details -
yaml: Register default representer with
OrderedDumper
tooThis does not change the behavior, but it does simplify the code.
Configuration menu - View commit details
-
Copy full SHA for b5ed823 - Browse repository at this point
Copy the full SHA b5ed823View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1171f5a - Browse repository at this point
Copy the full SHA 1171f5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d36bc3 - Browse repository at this point
Copy the full SHA 6d36bc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b85753 - Browse repository at this point
Copy the full SHA 0b85753View commit details -
tests: Use
salt.utils.yaml
to generate reference YAMLThe same YAML value can be represented in different ways, so tests that compare a generated YAML string with a manually typed string are fragile. Use `salt.utils.yaml` to generate the reference YAML so that the implementation of the YAML dumper can change without breaking the tests.
Configuration menu - View commit details
-
Copy full SHA for 60d8ed3 - Browse repository at this point
Copy the full SHA 60d8ed3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.