Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x][WIP] Handle StrictUndefined for all salt added jinja filters #65004

Open
wants to merge 7 commits into
base: 3006.x
Choose a base branch
from
Open

[3006.x][WIP] Handle StrictUndefined for all salt added jinja filters #65004

wants to merge 7 commits into from

Conversation

cmcmarrow
Copy link
Contributor

What does this PR do?

Handles StrictUndefined for all salt added jinja filters

What issues does this PR fix or reference?

Fixes: #64915

Previous Behavior

{{ dict['missing-key'] | yaml }} -> NULL

New Behavior

{{ dict['missing-key'] | yaml }} -> Rendering SLS error

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@cmcmarrow cmcmarrow requested a review from a team as a code owner August 17, 2023 00:41
@cmcmarrow cmcmarrow requested review from dwoz and removed request for a team August 17, 2023 00:41
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [WIP] Handle StrictUndefined for all salt added jinja filters [3006.x][WIP] Handle StrictUndefined for all salt added jinja filters Aug 17, 2023
@cmcmarrow cmcmarrow added this to the Sulfur v3006.4 milestone Aug 17, 2023
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 00:57 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 00:57 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 00:57 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 00:57 — with GitHub Actions Inactive
@cmcmarrow
Copy link
Contributor Author

we fail to check nested objects

@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 01:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 01:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 01:48 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 01:50 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 02:05 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 02:07 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 03:24 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 03:24 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 03:24 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 03:24 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 03:25 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci August 17, 2023 03:25 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Aug 17, 2023
@s0undt3ch s0undt3ch temporarily deployed to ci August 17, 2023 07:14 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 17, 2023 07:14 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 17, 2023 07:14 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 17, 2023 07:14 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci August 17, 2023 07:32 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 17:19 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 17:19 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 17:19 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 17:19 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 19:28 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 19:28 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 19:28 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 19:28 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 19:28 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 19:28 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 20:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 20:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 20:48 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 20:48 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 20:48 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci October 18, 2023 20:48 — with GitHub Actions Inactive
@dwoz dwoz modified the milestones: Sulfur v3006.4, Sulfur v3006.6 Dec 11, 2023
@dwoz dwoz modified the milestones: Sulfur v3006.6, Sulfur v3006.9 Jun 22, 2024
@dwoz dwoz requested a review from a team as a code owner February 17, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz Awaiting requested review from dwoz dwoz was automatically assigned from saltstack/team-core

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sulfur v3006.9
Development

Successfully merging this pull request may close these issues.
3 participants
@cmcmarrow @s0undt3ch @dwoz