-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Include the VM name with the IP address for Libvirt cloud logging #66860
base: 3006.x
Are you sure you want to change the base?
[3006.x] Include the VM name with the IP address for Libvirt cloud logging #66860
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to have a changelog entry for the PR. Also are current tests sufficient for this or at least there should be a test which verifies that the correct VM name is reported.
2f2f4f0
to
a00db32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't generally use pipes in our logs. I'd prefer that it (|
) is removed here. We'd also need a changelog entry to get this in.
What does this PR do?
This PR adds the VM name to the log output for Libvirt when the IP address is reported. This is helpful when running salt-cloud in parallel with -P to know which IP address belongs to which host.
What issues does this PR fix or reference?
There is not an issue for this PR.
Previous Behavior
New Behavior
Merge requirements satisfied?
If this is required for this change, then please let me know.
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.