Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x]Fix tech-debt for Git Pillar data with os.walk #67723

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Feb 10, 2025

What does this PR do?

Need to implement os.walk for handling traversal of Git Pillar branch names with a '/' slash in the Git branch name,

What issues does this PR fix or reference?

Fixes #67722

Previous Behavior

Previous behavior was to replace a '/' in the middle of a git branch name with a '-'

New Behavior

Leaves the git branch name unmodified and uses a os.walk to ensure the '/' in a git branch name is handled without modifying the git branch name behavior

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 self-assigned this Feb 10, 2025
@dmurphy18 dmurphy18 requested a review from a team as a code owner February 10, 2025 23:23
@dmurphy18 dmurphy18 added the test:full Run the full test suite label Feb 11, 2025
@dmurphy18 dmurphy18 added the test:os:all Run Tests Against ALL OS'es label Feb 13, 2025
@dmurphy18 dmurphy18 added this to the Sulfur v3006.10 milestone Feb 13, 2025
@dmurphy18 dmurphy18 changed the title [WIP][3006.x]Fix tech-debt for Git Pillar data with os.walk [3006.x]Fix tech-debt for Git Pillar data with os.walk Feb 14, 2025
@dmurphy18 dmurphy18 requested review from dwoz and twangboy February 14, 2025 20:42
@dwoz
Copy link
Contributor

dwoz commented Feb 17, 2025

@dmurphy18 The test:full label take precedence over all other labels. It runs the test suite just like we do for branch and nightly builds. So the test:os:full label is redundant here.

@dwoz dwoz merged commit 1d4c12e into saltstack:3006.x Feb 19, 2025
708 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite test:os:all Run Tests Against ALL OS'es
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants