Add deb package generation #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salty-horse
reviewed
Aug 29, 2020
DEBIAN/control
Outdated
| Architecture: amd64 | ||
| Maintainer: jrandiny <[email protected]> | ||
| Depends: ibus,python3,gir1.2-ibus-1.0,python3-levenshtein | ||
| Description: Ibus input method for entering emoji by name |
salty-horse
reviewed
Aug 29, 2020
README.md
Outdated
| @@ -28,6 +28,8 @@ Installing | |||
|
|
|||
| To install, type `make install`. If your ibus isn't on /usr/share/ibus, or you want to install to /usr/local, you can pass any of `PREFIX`, `DATADIR`, and `SYSCONFDIR` to `make`. You can also pass `DESTDIR` to aid in packaging, or `PYTHON` to use a different Python executable. | |||
|
|
|||
| For Ubuntu you can create a `.deb` file by running `make deb` and install with `sudo apt install ./<created_deb_filename>.deb` | |||
There was a problem hiding this comment.
Maybe mention Debian before Ubuntu since I assume this will work on all Debian-derived distributions.
salty-horse
reviewed
Aug 29, 2020
| deb: | ||
| make install DESTDIR=./deb-output/ | ||
| cp -r DEBIAN deb-output | ||
| sed -i "s/<currentversion>/$(CURRENTDATE)/" deb-output/DEBIAN/control |
There was a problem hiding this comment.
Maybe the makefile should include a proper version, and if you're building from git, the sha1 can be used, appended to the version.
There was a problem hiding this comment.
The problem with using sha1 for the version is that dpkg cannot determined which package is newer. How about date of last commit followed by the sha1?
There was a problem hiding this comment.
why not a proper version number for the deb package? i don't think a new deb should be generated per commit anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the ability to generate
.debfile for better package management