Merge pull request #35 from sam-cogan/samcogan/nide-version

update node version
sam-cogan · Nov 9, 2024 · 4048b6b · 4048b6b
2 parents 7ea3bd4 + fc2ef30
commit 4048b6b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/.github/workflows/build-extension-dev.yml b/.github/workflows/build-extension-dev.yml
@@ -62,7 +62,7 @@ jobs:
         cd ..
         npx tfx-cli extension create --manifest-globs vss-extension-dev.json
     - name: Upload artifact
-      uses: actions/upload-artifact@v1.0.0
+      uses: actions/upload-artifact@v4.0.0
       with:
         # Artifact name
         name: extension
@@ -72,7 +72,7 @@ jobs:
     needs: build
     steps:
     - name: Download artifact
-      uses: actions/download-artifact@v1.0.0
+      uses: actions/download-artifact@v4.0.0
       with:
         name: extension
     - name: run number with offset
@@ -82,5 +82,6 @@ jobs:
           echo "offset_build_number=$(($NUM+38))" >> $GITHUB_ENV
     - name: publish-extension
       run: |
-        npx tfx-cli extension publish --vsix extension/Sam-Cogan.ARMTTKExtensionXPlatform-Dev-1.0.${{env.offset_build_number}}.vsix --token ${{secrets.marketplace_pat}}
+        ls
+        npx tfx-cli extension publish --vsix Sam-Cogan.ARMTTKExtensionXPlatform-Dev-1.0.${{env.offset_build_number}}.vsix --token ${{secrets.marketplace_pat}}
         
diff --git a/.github/workflows/build-extension.yml b/.github/workflows/build-extension.yml
@@ -56,7 +56,7 @@ jobs:
         cd ..
         npx tfx-cli extension create --manifest-globs vss-extension.json
     - name: Upload artifact
-      uses: actions/upload-artifact@v1.0.0
+      uses: actions/upload-artifact@v4.0.0
       with:
         # Artifact name
         name: extension
@@ -75,7 +75,7 @@ jobs:
     needs: build
     steps:
     - name: Download artifact
-      uses: actions/download-artifact@v1.0.0
+      uses: actions/download-artifact@v4.0.0
       with:
         name: extension
     - name: publish-extension

diff --git a/arm-ttk-extension-xplatform/task.json b/arm-ttk-extension-xplatform/task.json
@@ -11,7 +11,7 @@
     "author": "Sam Cogan",
     "version": {
         "Major": 1,
-        "Minor": 3,
+        "Minor": 4,
         "Patch": 1
     },
     "instanceNameFormat": "Run Azure RM TTK Tests (Cross Platform)",
@@ -123,6 +123,9 @@
     "execution": {   
         "Node10": {
             "target": "ttk.js"
+        },
+        "Node20_1": {
+          "target": "ttk.js"
         }
     }
 }