Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intensity field to pointcloud #44

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

nikhil-sethi
Copy link

@nikhil-sethi nikhil-sethi commented Oct 11, 2024

Description of MR:

The partial profile data content was changed to include intensity in the field. Based on the work in https://github.com/ipa-mdh/scancontrol/tree/christian/fix_install_with_intensity

Depends on #38

Motivation and Context

Resin flash and inhomogenous surfaces can have varying intensities in a laser scan and it can help to have the maximum intensity as a field in the point cloud.

Changes

  1. Change partial profile data size and data start to include intensity values
  2. Update the point cloud frame id to match with TFs

Type of changes

  • Features

@nikhil-sethi nikhil-sethi added enhancement New feature or request need for sprint This needs to be closed to complete the active sprint labels Oct 14, 2024
@gavanderhoorn
Copy link
Member

Please prefer to rebase instead of merging.

@nikhil-sethi
Copy link
Author

Please prefer to rebase instead of merging.

Yes agreed. I will rebase and clear it up once previous PRs are merged

@nikhil-sethi nikhil-sethi removed the request for review from dave992 October 17, 2024 13:39
- also updated pcd frame_id to correspond with TFs
Copy link

@erichlf erichlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikhil-sethi nikhil-sethi merged commit f9801c0 into ros2-devel Oct 18, 2024
2 checks passed
@nikhil-sethi nikhil-sethi deleted the intensity_pcd branch October 18, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request need for sprint This needs to be closed to complete the active sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants