add retry loop to ctdb-must-have-node command #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
force-pushed
the
jjm-robuster-ctdbmusthave
branch
from
1f958c8
to
b267218
Compare
|
@Mergifyio rebase |
Signed-off-by: John Mulligan <[email protected]>
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-robuster-ctdbmusthave
branch
from
b267218
to
65c6ff7
Compare
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
ok mergify whatever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was shown a cluster that had failed to communicate with rados during the
ctdb-must-have-nodecommand, after it had at least correctly read "nothing".Add a retry loop (with limit) to the command to make it robust against spurious errors.