Add centos 10 CI job #177
Add centos 10 CI job #177
Conversation
|
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
This looks good to me. I should be able to incorporate the changes from #175 into this pretty easily.
Start to prepare for centos stream10 build support by moving things that not all versions support out of the packages list and adding a set of distro-conditional actions in. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-centos10
branch
from
2487511 to
3420d5c
Compare
It should. Unless rhel is doing something very odd, it should work similarly to how the COPR enables the package on centos 10. |
|
Speaking of the COPR - @anoopcs9 do you want to request an EPEL 10 package for python-inotify_simple or shall I? |
Done. bz #2402542 |
We have it explicitly on fedora and implicitly on centos 9, so it has coverage, just not on in the c10 job. (and that applies to py39, the unit tests env, as well as py39-mypy for type checking) I figure we can continue building/testing on centos stream 9 until it becomes an annoyance. Possibly because we want to use a python 3.10 or later feature :-) and it would also have to be after we switch the base images of samba-container (devbuilds and/or whatever we are pairing with ceph) to something EL10 based. Make sense? |
There was a problem hiding this comment.
I forgot to ask last time.
So we are OK to not have py39-mypy on CentOS Stream 10? How long do we plan to carry this forward with CentOS Stream 9?We have it explicitly on fedora and implicitly on centos 9, so it has coverage, just not on in the c10 job. (and that applies to py39, the unit tests env, as well as py39-mypy for type checking)
Sorry, I didn’t get the part that says "implicitly on centos 9" in relation to the py39 test env.
I figure we can continue building/testing on centos stream 9 until it becomes an annoyance. Possibly because we want to use a python 3.10 or later feature :-) and it would also have to be after we switch the base images of samba-container (devbuilds and/or whatever we are pairing with ceph) to something EL10 based.
Make sense?
Well, I don't mind dropping the py39 test env and have something which runs on all distro versions.
3 participants
Depends on: #176
I don't always like 'dueling prs' but I needed to try some stuff out and this was the simplest way.
Overlaps with #173 and #175 - but I can't help it because I wanted to test adding a new CI job.