Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gemini schema's oneOf detection logic. #93

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

samchon
Copy link
Owner

@samchon samchon commented Nov 29, 2024

This pull request includes several changes to the @samchon/openapi package, focusing on improving schema validation and adding new test cases for the Gemini converter. The most important changes include updating the package version, enhancing the validation logic in ChatGptConverter and GeminiConverter, and adding new test cases for schema validation.

Version Update:

  • Updated the package version in package.json to 2.0.0-dev.20241129-4.

Validation Enhancements:

Test Cases:

  • Added a new test case test_gemini_schema_enum to validate enum schemas in test/features/llm/gemini/test_gemini_schema_enum.ts.
  • Added a new test case test_gemini_schema_nullable to validate nullable schemas in test/features/llm/gemini/test_gemini_schema_nullable.ts.

Utility Imports:

@samchon samchon added bug Something isn't working enhancement New feature or request labels Nov 29, 2024
@samchon samchon self-assigned this Nov 29, 2024
Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, successfully fixed.

@samchon samchon merged commit 39dd08a into master Nov 29, 2024
4 checks passed
@samchon samchon deleted the feat/additionalProperties branch November 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant