-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nim 2 support #58
Nim 2 support #58
Conversation
It conflicts with a built in nimble task
Looks good! I'll test this soon. |
I'm good with |
The README can also be updated replacing the corresponding line in the prerequisites |
I think Ive addressed all the feedback whenever you are ready to take another look |
I'm going to test this again, one thing I noticed last time was that the |
I think this has a merge conflict with the other PR I submitted, so I’ll need to resolve that |
At this point, all the tangible changes to the actual configuration were done as part of #60, so this PR is really just about updating the github workflows to build against both Nim 1.6 and Nim 2 |
Works on macOS, I just get a bunch of warnings ( Other than that, the |
This allows the default clean task to run, while adding custom behavior specifically for playdate cleaning
Fixes samdze#17
Updated to fix the |
Does it work on your setup? |
Also I noticed a previous action run on the same PR generated an error: https://github.com/samdze/playdate-nim/actions/runs/8352993144/job/22880677174?pr=58 Don't know what happened, hopefully not a random memory corruption issue |
I’ll poke at the clean task some more this morning. I didn’t check the version of nimble I was using, I only flipped between Nim 1.6 and 2. The build failure has been happening for a few months, so it’s unrelated to any recent changes. I was able to repro it in valgrind at one point, which pointed to a null access in the simulator itself, so I didn’t dig in much further. We can probably add a retry to that workflow and ignore it. |
If this causes too much trouble right now, let's just rename our clean routine to one of |
No trouble — I just ran out of time this week. I’ll try to find some hours to look at this again this weekend |
I didn't investigate, but at first glance it seems that Let me know whether you'd like to address the |
Apologies for not getting back to this. Technically, Nim 2 works at this point because of the memory management changes we made, so this hasn’t been high on my priority list |
Thank you Nycto. Finally merged this! |
This change refactors the build scripts a bit to support building on both
1.6.14
and2.0.2
, and adds support for building against Nim 2. The only thing that really needed to change wasswitch("define", "useMalloc")