Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build trigger for tags #494

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Fix build trigger for tags #494

merged 2 commits into from
Mar 11, 2022

Conversation

jcormier
Copy link
Collaborator

@jcormier jcormier commented Mar 8, 2022

The tags we use don't have v in them.

The tags we use don't have v in them.
@jcormier
Copy link
Collaborator Author

jcormier commented Mar 8, 2022

Fixes for #474

@jcormier
Copy link
Collaborator Author

jcormier commented Mar 8, 2022

Will need to manually kick of the github actions for tags 4.1.6 and 4.2.4

@jcormier jcormier requested a review from sameersbn March 8, 2022 18:03
@jcormier jcormier merged commit 4f7a9c1 into master Mar 11, 2022
@jcormier jcormier deleted the workflow-tag-fix branch March 11, 2022 14:20
@jcormier
Copy link
Collaborator Author

Going to try to delete and push tags to see if it will kick off builds

@frank-dspeed
Copy link
Collaborator

@jcormier you should simply first switch to on dispatch and manual dispatch the builds till we found a good pattern that would make less noise we could create a extra repo to test the builds and when that works simply copy paste.

@jcormier
Copy link
Collaborator Author

I don't have permissions to trigger dispatch builds. But that's a good idea, I could set up things in my fork of the project and test various configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants