Send Content-Type only if there is data, relative post location #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The content type issue addressed here causes issues with servers that are very strict - for example senchalabs/connect#680. Would be nice to see this fixed (for GET requests too). |
|
Looks good to me. |
If we get 201 response with no location header, treat is as 200
Make slumber not crash on 201 response without Location header
|
Can we not get this merged? |
|
@alithorn still "active", maintenance mostly - I'll get this merged when I get a moment. |
|
@samgiles I apologize if I sound(ed) presumptuous. Starting a large project and I seriously appreciate the abstraction you are providing but I'm shit scared of having to support a branch of my own if it takes 3 years to get a good change merged... |
samgiles
pushed a commit
that referenced
this pull request
Apr 24, 2017
|
The content-type issue is now in master, tracking the location stuff in #138, will need to check test coverage. |
gusibi
pushed a commit
to gusibi/slumber
that referenced
this pull request
Jul 25, 2018
…payload is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for two fixes in single pull request.
PUTandDELETEmethods should only sendContent-typeheader if there request has data.If
Locationheader is not full URL (doesn't start with http/s) it can be passed asidparameter andurl_joinfunction will joinLocationwithbase_path.