Extract hostname with URL #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t use the host (can contain `:$port_number`) but the hostname.
|
This change would mean that sites hosted on a non-standard port would no longer have their dat version detected, correct? Was there a specific case you observed that this change aims to fix? |
|
This change aligns the behaviour with dat-dns. RFC5785 says to use HTTP or HTTPS but to discover services for a hostname. Web services running on non-standard ports aren’t supposed to be used for service auto-discovery. |
|
Thanks for the explanation. In that case shouldn't the discovery stop if a non-default port is given? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t use the host (can contain
:$port_number) but the hostname.