Step 1 — Switch from React to Preact #2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| process.env.BABEL_ENV = 'production'; | ||
| process.env.NODE_ENV = 'production'; | ||
|
|
||
| const webpackPreact = require('./patch/webpackPreact'); | ||
| const webpackConfig = require('react-scripts/config/webpack.config.prod'); | ||
| webpackPreact(webpackConfig); | ||
|
|
||
| require('react-scripts/scripts/build'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // Hack the webpack config to load Preact instead of React | ||
| module.exports = webpackConfig => | ||
| (webpackConfig.resolve.alias = Object.assign({}, webpackConfig.resolve.alias, { | ||
| react: 'preact-compat', | ||
|
There was a problem hiding this comment. whenever |
||
| 'react-dom': 'preact-compat' | ||
| })); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| process.env.BABEL_ENV = 'development'; | ||
| process.env.NODE_ENV = 'development'; | ||
|
|
||
| const webpackPreact = require('./patch/webpackPreact'); | ||
| const webpackConfig = require('react-scripts/config/webpack.config.dev'); | ||
| webpackPreact(webpackConfig); | ||
|
|
||
| require('react-scripts/scripts/start'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| process.env.BABEL_ENV = 'test'; | ||
| process.env.NODE_ENV = 'test'; | ||
|
|
||
| // Load the create-react-app config. | ||
| const jestConfig = require('react-scripts/scripts/utils/createJestConfig'); | ||
|
|
||
| // Map React's testing classes to Preact | ||
| const newJestConfig = function() { | ||
| const config = jestConfig.apply(this, arguments); | ||
| config.moduleNameMapper = Object.assign({}, config.moduleNameMapper, { | ||
|
There was a problem hiding this comment. whenever |
||
| '^react-dom/server$': '<rootDir>/node_modules/preact-render-to-string/dist/index.js', | ||
| '^react-dom/test-utils$': '<rootDir>/node_modules/preact-test-utils/lib/index.js', | ||
| '^react-dom$': '<rootDir>/node_modules/preact-compat-enzyme/lib/index.js', | ||
| '^react-test-renderer/shallow$': '<rootDir>/node_modules/preact-test-utils/lib/index.js', | ||
| '^react-test-renderer$': '<rootDir>/node_modules/preact-test-utils/lib/index.js', | ||
| '^react-addons-test-utils$': '<rootDir>/node_modules/preact-test-utils/lib/index.js', | ||
| '^react$': '<rootDir>/node_modules/preact-compat-enzyme/lib/index.js' | ||
| }); | ||
| return config; | ||
| }; | ||
|
|
||
| // HACK ALERT! | ||
| module.constructor._cache[ | ||
|
There was a problem hiding this comment. HACK ALERT!Preload Node's module cache with the hacked |
||
| require.resolve('react-scripts/scripts/utils/createJestConfig') | ||
| ].exports = newJestConfig; | ||
|
|
||
| // Run the build. | ||
| require('react-scripts/scripts/test'); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`can render into snapshots 1`] = ` | ||
| <div | ||
| class="App" | ||
| > | ||
| <header | ||
| class="App-header" | ||
| > | ||
| <img | ||
| alt="logo" | ||
| class="App-logo" | ||
| src="logo.svg" | ||
| /> | ||
| <h1 | ||
| class="App-title" | ||
| > | ||
| Welcome to React | ||
| </h1> | ||
| </header> | ||
| <p | ||
| class="App-intro" | ||
| > | ||
| To get started, edit | ||
| <code> | ||
| src/App.js | ||
| </code> | ||
| and save to reload. | ||
| </p> | ||
| <div | ||
| class="thing" | ||
| /> | ||
| </div> | ||
| `; | ||
|
|
||
| exports[`can shallow render into snapshots 1`] = ` | ||
| <div | ||
| class="App" | ||
| > | ||
| <header | ||
| class="App-header" | ||
| > | ||
| <img | ||
| alt="logo" | ||
| class="App-logo" | ||
| src="logo.svg" | ||
| /> | ||
| <h1 | ||
| class="App-title" | ||
| > | ||
| Welcome to React | ||
| </h1> | ||
| </header> | ||
| <p | ||
| class="App-intro" | ||
| > | ||
| To get started, edit | ||
| <code> | ||
| src/App.js | ||
| </code> | ||
| and save to reload. | ||
| </p> | ||
| <Thing /> | ||
| </div> | ||
| `; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import render, { shallowRender } from 'preact-render-to-json'; | ||
|
|
||
| /** | ||
| * Remove __self and __source from the list of attributes/properties. | ||
| * babel-preset-react adds these for use with the React DevTools | ||
| */ | ||
| function removeDevAttributes(vnode) { | ||
|
There was a problem hiding this comment.
We need this small patch to make them go away and have reliable snapshot testing. See preactjs/preact-render-to-string#43 (comment) for more info. |
||
| if (vnode) { | ||
| if (vnode.children) { | ||
| vnode.children.forEach(n => removeDevAttributes(n)); | ||
| } | ||
| if (vnode.props) { | ||
| if (vnode.props.__source) { | ||
| delete vnode.props.__source; | ||
| } | ||
| if (vnode.props.__self) { | ||
| delete vnode.props.__self; | ||
| } | ||
| } | ||
| } | ||
| return vnode; | ||
| } | ||
|
|
||
| /** | ||
| * Render Preact JSX + Components to an HTML string. | ||
| * | ||
| * @param {VNode} vnode JSX VNode to render. | ||
| * @param {Object} [context={}] Optionally pass an initial context object through the render path. | ||
| * @param {Object} [options={}] Rendering options | ||
| */ | ||
| global.render = (vnode, context) => removeDevAttributes(render(vnode, context)); | ||
|
|
||
| global.shallowRender = (vnode, context) => removeDevAttributes(shallowRender(vnode, context)); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting rid of
reactandreact-dom