Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 2 — Set Babel’s IE target from 9 to 11 #3

Open
wants to merge 1 commit into
base: 01-preact
Choose a base branch
from
Open

Step 2 — Set Babel’s IE target from 9 to 11 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
process.env.BABEL_ENV = 'production';
process.env.NODE_ENV = 'production';

const babelIE11 = require('./patch/babelIE11');
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The babel config needs to be patched before the webpack config, otherwise we're too late and it won't take effect.

const babelConfig = require('babel-preset-react-app');
babelIE11(babelConfig);

const webpackPreact = require('./patch/webpackPreact');
const webpackConfig = require('react-scripts/config/webpack.config.prod');
webpackPreact(webpackConfig);
Expand Down
14 changes: 14 additions & 0 deletions scripts/patch/babelIE11.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Hack babel to build for IE11 instead of IE9
module.exports = babelConfig => {
const presets = babelConfig.presets;
presets.forEach((preset, i) => {
if (!Array.isArray(preset)) {
return;
}
preset.forEach((p, j) => {
if (p.targets && p.targets.ie) {
presets[i][j].ie = 11;
}
});
});
};
4 changes: 4 additions & 0 deletions scripts/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
process.env.BABEL_ENV = 'development';
process.env.NODE_ENV = 'development';

const babelIE11 = require('./patch/babelIE11');
const babelConfig = require('babel-preset-react-app');
babelIE11(babelConfig);

const webpackPreact = require('./patch/webpackPreact');
const webpackConfig = require('react-scripts/config/webpack.config.dev');
webpackPreact(webpackConfig);
Expand Down