-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Binary Upload (Fixes #2126) #2331
base: main
Are you sure you want to change the base?
Conversation
deb292b
to
d8b837c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2331 +/- ##
==========================================
- Coverage 95.32% 95.31% -0.02%
==========================================
Files 381 381
Lines 22823 22854 +31
Branches 517 518 +1
==========================================
+ Hits 21756 21783 +27
- Misses 550 553 +3
- Partials 517 518 +1 |
d19d3d3
to
b83d9e9
Compare
15c9a5c
to
2293cb2
Compare
b718330
to
78c8bf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not look at the unit tests, will do that after you worked on the current issues
1ffb7bb
to
1d299e5
Compare
1d299e5
to
80ae128
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please review this again?
My only doubt is whether we should keep the debugging code in the integration test. I think it may be useful in the future...
0006a11
to
6fa4273
Compare
bf97a8a
to
576049a
Compare
Extras: * Overhaul the unit tests to ease debugging, bug finding, and making sure we are fully following the spec. * Fix: add missing status and content type for non-binary responses. (This bug was discovered by the new tests.)
576049a
to
af16b87
Compare
No description provided.