Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep develop in sync with main #221

Merged
merged 25 commits into from
Oct 15, 2024
Merged

Keep develop in sync with main #221

merged 25 commits into from
Oct 15, 2024

Conversation

lablans
Copy link
Member

@lablans lablans commented Aug 30, 2024

No description provided.

Croft and others added 23 commits January 25, 2024 13:49
In ENVIRONMENT=production, use main tag for Samply.Beam.
Recommendation for standalone Bridgehead
Configure beam-connect to trust ds-orchestrator beam proxy
Update Develop from Main
Deactivate traefik dashboard by default. Add trailing slash to PathPrefix to clarify the URL the dashboard is available at.
Before this change CentraXX was redirected to the
central login servers then interacting with the id-management
feature: log git branches to healthchecks and code refactoring
Allow Usage of Centraxx Interface without login
fix: deactivate landingpage for KR project
@torbrenner torbrenner marked this pull request as ready for review October 10, 2024 09:20
Copy link
Contributor

@PierreDelpy PierreDelpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Features like Search, Export, QB and routine operation have been tested without any abnormalities

@Threated
Copy link
Member

This will downgrade beam to main but there were no breaking changes introduced and no major bug fixes so it should be fine. Will make a new beam release soon™ anyway.


services:
blaze:
image: docker.verbis.dkfz.de/cache/samply/blaze:0.28
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move version number into variable

@@ -57,7 +65,7 @@ services:
- "/tmp/bridgehead/patientlist/:/docker-entrypoint-initdb.d/"

traefik-forward-auth:
image: docker.verbis.dkfz.de/cache/oauth2-proxy/oauth2-proxy:v7.6.0
image: docker.verbis.dkfz.de/cache/oauth2-proxy/oauth2-proxy:latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move version number into variable

- "blaze"

beam-proxy:
image: docker.verbis.dkfz.de/cache/samply/beam-proxy:develop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is tag develop intended? Can the tag be externalized into a variable?


BROKER_URL_FOR_PREREQ=$BROKER_URL

POSTGRES_TAG=15.6-alpine
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a standard version -- can it go into a shared config?


services:
exporter:
image: docker.verbis.dkfz.de/ccp/dktk-exporter:latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move version number into variable



teiler-backend:
image: docker.verbis.dkfz.de/ccp/dktk-teiler-backend:latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move version number into variable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have duplicate files like this a some kind of "git symlink"?

Comment on lines 173 to +174
export BLAZE_RESOURCE_CACHE_CAP=128000;
export BLAZE_CQL_CACHE_CAP=32;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export BLAZE_RESOURCE_CACHE_CAP=128000;
export BLAZE_CQL_CACHE_CAP=32;
export BLAZE_RESOURCE_CACHE_CAP=128000
export BLAZE_CQL_CACHE_CAP=32

else
export BLAZE_RESOURCE_CACHE_CAP=$((available_system_memory_chunks * 312500))
export BLAZE_CQL_CACHE_CAP=$((($system_memory_in_mb/4)/16));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export BLAZE_CQL_CACHE_CAP=$((($system_memory_in_mb/4)/16));
export BLAZE_CQL_CACHE_CAP=$((($system_memory_in_mb/4)/16))

Comment on lines +58 to +64
itcc)
site_configuration_repository_middle="git.verbis.dkfz.de/itcc-sites/"
;;
dhki)
site_configuration_repository_middle="git.verbis.dkfz.de/dhki/"
;;
kr)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
itcc)
site_configuration_repository_middle="git.verbis.dkfz.de/itcc-sites/"
;;
dhki)
site_configuration_repository_middle="git.verbis.dkfz.de/dhki/"
;;
kr)
itcc)
site_configuration_repository_middle="git.verbis.dkfz.de/itcc-sites/"
;;
dhki)
site_configuration_repository_middle="git.verbis.dkfz.de/dhki/"
;;
kr)

* feat: add auto archiving action

---------

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Martin Lablans <[email protected]>
@PierreDelpy PierreDelpy merged commit 75089ab into main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants