Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix form of questionnaireresponseitemanswer #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mharper-imaware
Copy link

json provided for mock questionnaireresponse item(https://www.hl7.org/fhir/questionnaireresponse-examples.html) would not parse into current structure. Fixed structure for QuestionnaireResponseItemAnswer

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PontusNyberg
Copy link

Another way of doing this could be just adding a new struct instead of Extensions or leave extensions for that matter. A new struct that takes Value of *interface or maybe even a generic and a Type of *string where the type is described eg. "int64" or "bool".

Copy link

@ivan-navi-studios ivan-navi-studios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting does not align with the rest of the project. Besides that looks good

@mharper-imaware
Copy link
Author

The formatting does not align with the rest of the project. Besides that looks good

@ivan-navi-studios what formatting needs to change?

@garywarner
Copy link

@mharper-imaware I think @ivan-navi-studios meant that it hadn't had go fmt run on it, so the tabbing and spacing was wrong... but I also think that was a github "moment", because it looks fine today and you haven't committed. Perhaps @ivan-navi-studios would be kind enough to take another look now?

For me, https://build.fhir.org/questionnaireresponse.html#QuestionnaireResponse.item has the answer as a backbone element, so it should have id, extension (from Element) and modifierExtension (from BackboneElement) as well as the individual answer I think. So, adding your new items and retaining the previous ones would be a solution.

I'd be keen to see this resolved as I use the library and next month's project involves a FHIR Questionnaire...

@PontusNyberg
Copy link

PontusNyberg commented May 24, 2022

I realize my comment goes away from the fhir structure.
I agree with @garywarner, i would like to see the id, extension and modifierExtension added back then this merged. We're currently working with adding Questionnaires and its a bit annoying to add this whole structure because we're missing this PR.

@alexanderkiel
Copy link
Member

Sorry, I've currently no time to look at this PR. Please fork if you like to have this feature.

@garywarner
Copy link

@alexanderkiel Just a note from myself (and reading other issues, many other people) to say thank you for the efforts in making this available to the Go FHIR community - it's really appreciated and I'm sure we all understand the pressures of work and other commitments.

@garywarner
Copy link

@mharper-imaware @PontusNyberg @ivan-navi-studios PR #7 to support polymorphic types resolves the underlying issue that this PR is attempting to resolve within the generator, rather than adding to the generated fields.

@PontusNyberg
Copy link

@garywarner Yes i've realized this. I've since then forked this repo and implemented that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants