-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix form of questionnaireresponseitemanswer #11
base: master
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Another way of doing this could be just adding a new struct instead of Extensions or leave extensions for that matter. A new struct that takes Value of *interface or maybe even a generic and a Type of *string where the type is described eg. "int64" or "bool". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting does not align with the rest of the project. Besides that looks good
@ivan-navi-studios what formatting needs to change? |
@mharper-imaware I think @ivan-navi-studios meant that it hadn't had For me, https://build.fhir.org/questionnaireresponse.html#QuestionnaireResponse.item has the answer as a backbone element, so it should have id, extension (from Element) and modifierExtension (from BackboneElement) as well as the individual answer I think. So, adding your new items and retaining the previous ones would be a solution. I'd be keen to see this resolved as I use the library and next month's project involves a FHIR Questionnaire... |
I realize my comment goes away from the fhir structure. |
Sorry, I've currently no time to look at this PR. Please fork if you like to have this feature. |
@alexanderkiel Just a note from myself (and reading other issues, many other people) to say thank you for the efforts in making this available to the Go FHIR community - it's really appreciated and I'm sure we all understand the pressures of work and other commitments. |
@mharper-imaware @PontusNyberg @ivan-navi-studios PR #7 to support polymorphic types resolves the underlying issue that this PR is attempting to resolve within the generator, rather than adding to the generated fields. |
@garywarner Yes i've realized this. I've since then forked this repo and implemented that one. |
json provided for mock questionnaireresponse item(https://www.hl7.org/fhir/questionnaireresponse-examples.html) would not parse into current structure. Fixed structure for QuestionnaireResponseItemAnswer