Authentik #2
Merged
Authentik #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Threated
requested changes
Jan 8, 2025
central/src/auth/config.rs
Outdated
Comment on lines
15
to
33
| /// Central secret sync | ||
| #[derive(Debug, Parser)] | ||
| pub struct Config { | ||
| /// Address the server should bind to | ||
| #[clap(env, long, default_value = "0.0.0.0:8080")] | ||
| pub bind_addr: SocketAddr, | ||
|
|
||
| /// Url of the local beam proxy which is required to have sockets enabled | ||
| #[clap(env, long, default_value = "http://beam-proxy:8081")] | ||
| pub beam_url: Url, | ||
|
|
||
| /// Beam api key | ||
| #[clap(env, long)] | ||
| pub beam_secret: String, | ||
|
|
||
| /// The app id of this application | ||
| #[clap(long, env, value_parser=|id: &str| Ok::<_, Infallible>(AppId::new_unchecked(id)))] | ||
| pub beam_id: AppId, | ||
| } |
There was a problem hiding this comment.
Move this central/src/config.rs without bind_addr
added 2 commits
January 9, 2025 16:08
|
The two new commits look good to me. I need to take a look at the full changes again then I think its ready to merge |
Threated
requested changes
Jan 27, 2025
central/src/auth/authentik/test.rs
Outdated
Comment on lines
68
to
91
| #[cfg(test)] | ||
| // nicht möglich mit authentik | ||
| async fn get_access_token_via_admin_login() -> reqwest::Result<String> { | ||
| CLIENT | ||
| .post(&format!( | ||
| "{}/application/o/token/", | ||
| if cfg!(test) { | ||
| "http://localhost:9000" | ||
| } else { | ||
| "http://authentik:8080" | ||
| } | ||
| )) | ||
| .form(&json!({ | ||
| "client_id": "", | ||
| "username": "", | ||
| "password": "", | ||
| "grant_type": "" | ||
| })) | ||
| .send() | ||
| .await? | ||
| .json::<Token>() | ||
| .await | ||
| .map(|t| t.access_token) | ||
| } |
There was a problem hiding this comment.
Delete all fn that don’t work in tests
central/src/auth/authentik/test.rs
Outdated
| .map(|t| t.access_token) | ||
| } | ||
|
|
||
| //#[ignore = "Requires setting up a authentik"] |
Co-authored-by: Jan <[email protected]>
Threated
reviewed
Feb 4, 2025
central/src/auth/authentik/test.rs
Outdated
| assert!(!t.access_token.is_empty()); | ||
| } | ||
|
|
||
| //#[ignore = "Requires setting up a authentik"] |
There was a problem hiding this comment.
This test still needs to be ignored again
added 2 commits
February 4, 2025 13:59
Threated
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider and app can be created.
static flow and property is missing