Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blog Post] Add Blog post for Bril array & arguments extensions #429
base: 2023fa
Are you sure you want to change the base?
[Blog Post] Add Blog post for Bril array & arguments extensions #429
Changes from 1 commit
3d617bf
a2bbda8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to include section headings that directly mirror my bullet points from the syllabus. Remember that your imaginary audience here is people who are generally interested in compilers and your work but do not particularly care that this was done as a 6120 project. Do you think there's a different way to title these sections that would more accurately reflect the contents and help such a reader more quickly navigate your writing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using a "," after occurrences of "e.g." and "i.e.". https://capra.cs.cornell.edu/styleguide/#egie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"TypeScript compiler": I think you mean the reference interpreter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"We evaluate the Bril type of the array, allocate an array in Bril": Seems like this is maybe missing some words… do you mean something like "to evaluate […], we generate code to […]"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This honestly makes sense to me! It is a weird mismatch between TS and Bril in general that TS has only one type (
number
) that in Bril would intuitively cover two different types (int
andfloat
). So I have mostly (not entirely) made the decision to force TS programs to use two types (bigint
andnumber
) to distinguish.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in general, the TS-to-Bril compiler already gleefully emits a lot of dead code!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you still have them in your history, do you think you could include a couple of links to StackOverflow posts that helped you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had not seen that AST viewer! That's pretty cool. It would have saved me a lot of time in my days of hacking on TS compiler internals…