This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add lane to upload dSyms to Crashlytics #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccmjz
approved these changes
Mar 19, 2018
rsomlette
reviewed
Mar 19, 2018
Fastfile
Outdated
| @@ -202,6 +202,18 @@ platform :ios do | |||
| !ENV['BITRISE_IO'].nil? | |||
| end | |||
|
|
|||
| desc 'Downloads dSYM from iTuneConnect and upload them to Crashlytics.' | |||
| lane :refresh_dsyms do | |||
| if ENV['CRASHLYTICS_API_TOKEN'] || ENV['GOOGLE_SERVICES_INFO_PLIST_PATH'] | |||
There was a problem hiding this comment.
@rsomlette yes, will change this.
1nput0utput
force-pushed
the
feature/upload_dsyms
branch
from
d56c373
to
17894bb
Compare
ccmjz
reviewed
Mar 19, 2018
Fastfile
Outdated
| @@ -202,6 +202,18 @@ platform :ios do | |||
| !ENV['BITRISE_IO'].nil? | |||
| end | |||
|
|
|||
| desc 'Downloads dSYM from iTuneConnect and upload them to Crashlytics.' | |||
| lane :refresh_dsyms do | |||
| if !ENV['CRASHLYTICS_API_TOKEN'] || !ENV['GOOGLE_SERVICES_INFO_PLIST_PATH'] | |||
There was a problem hiding this comment.
@ccmjz it's either one or the other. If we're using Firebase Crashlytics we have to set GOOGLE_SERVICES_INFO_PLIST_PATH otherwise CRASHLYTICS_API_TOKEN for the original Crashlytics.
There was a problem hiding this comment.
So we should raise the error when none of them is set, right? If we use the || here, the error will be raised if one of them is not set.
There was a problem hiding this comment.
@ccmjz yes, you're right. In my haste, I made this stupid error.
rsomlette
approved these changes
Mar 19, 2018
1nput0utput
force-pushed
the
feature/upload_dsyms
branch
from
17894bb
to
3b78b03
Compare
1nput0utput
force-pushed
the
feature/upload_dsyms
branch
from
3b78b03
to
a42523e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This lane
refresh_dsymswill download debug symbols from iTC and upload them to Crashlytics.It is necessary to have dSyms in Crashlytics to decode a crash stack trace.
Developer must set either
CRASHLYTICS_API_TOKENorGOOGLE_SERVICES_INFO_PLIST_PATHin order to upload the dSyms. TheGOOGLE_SERVICE_INFO_PLIST_PATHenvironment variable is used if you're using Firebase Crashlytics.