-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change cli #8
base: master
Are you sure you want to change the base?
Change cli #8
Conversation
When someone runs the |
|
||
module Sentry | ||
|
||
class SentryCommand < Cli::Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is a Crystal standard to capitalize acronyms (e.g. CLI, HTTP, JSON)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but I don't know if @mosop will change the name now :/
Also, the current CLI installation process does not use shards or dependencies, so we will need to figure that out. Correct me if I'm wrong, but I don't believe shards has support for installing CLI tools as a dependency. |
I updated the install.rb file to take in account the modifications. ( I completely forgot it 😝 ) |
Seeing as this will introduce a dependency, is there a way to install Sentry while installing dependencies at the same time? Does shards support that feature? I like what you did to |
Also they way you are loading the app name in the CLI dynamically is a no brainer. 👍 That will be much better. Glad I could get some other eyes on this project to help button it up. I would however make the |
You may want to look at Admiral as well: https://github.com/jwaldrip/admiral.cr |
Move from OptionParser to Cli for better integration