Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shell parser to separate entry and args for command #1

Open
wants to merge 1 commit into
base: optional_command
Choose a base branch
from

Conversation

vietjtnguyen
Copy link

Tested with a somewhat strange node app.js -c "/bin/bash -xc \"echo hello & /bin/bash\"" -p 80 and got the expected output:

+ /bin/bash
+ echo hello
hello
[root@fbffe09cdd9b wetty]# 

@samuelson
Copy link
Owner

Can you help me understand why this is needed? I think I would prefer to use a script as the command rather than add more complexity to the app itself.

@samuelson
Copy link
Owner

Also, I don't really want to merge anything until this is merged upstream.

@vietjtnguyen
Copy link
Author

It's just sort of canonically extensible. This way I can now run

node app.js -p 80 -c "tmux attach"

in my Docker container to attach to interactively inspect and check my long running process. Sure you can create a shell script

echo "#!/bin/bash" >> tmux-attach.sh
echo "tmux attach" >> tmux-attach.sh
chmod u+x tmux-attach.sh
node app.js -p 80 -c ./tmux-attach.sh

but it seems a little unnecessary to me.

Feel free to defer this until your current branch state is merged.

samuelson pushed a commit that referenced this pull request Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants