Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to LatLonType from Solr schema #1376

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Remove references to LatLonType from Solr schema #1376

merged 3 commits into from
Apr 3, 2019

Conversation

no-reply
Copy link
Contributor

This type is deprecated in Solr. Its removal from the template here shouldn't
affect existing adopters who may be using it. It will be removed only for folks
running the generator after this commit.

Fixes #1370

This type is deprecated in Solr. Its removal from the template here shouldn't
affect existing adopters who may be using it. It will be removed only for folks
running the generator after this commit.

Fixes #1370
@coveralls
Copy link

coveralls commented Jan 23, 2019

Coverage Status

Coverage increased (+0.01%) to 89.569% when pulling 056f436 on solr-latlon into 76e18a1 on master.

Copy link
Member

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative would be to use LatLonPointSpatialField see projectblacklight/blacklight@bed6f04#diff-049ccaa11fc261c1090e98d2e13a0713

@cjcolvar
Copy link
Member

@no-reply What do you think about incorporating @jcoyne 's suggestion?

@bess
Copy link
Member

bess commented Apr 3, 2019

@jcoyne After conversations with @cjcolvar about this, we put your suggestion into a separate issue, here: #1381

@bess bess merged commit 03780e0 into master Apr 3, 2019
@bess bess deleted the solr-latlon branch April 3, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants