Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base image #2268

Closed
wants to merge 2 commits into from
Closed

Update base image #2268

wants to merge 2 commits into from

Conversation

ShanaLMoore
Copy link
Collaborator

Summary

This change is necessary because Hyrax main now uses Ruby 3.2.

Otherwise, building the latest Hyku fails with this error:

29.78 Because every version of hyrax depends on Ruby >= 3.2
29.78   and Gemfile depends on hyrax >= 0,
29.78   Ruby >= 3.2 is required.
29.78 So, because current Ruby version is = 2.7.7,
29.78   version solving has failed.
docker run -it --rm ghcr.io/samvera/hyku/base:latest bash => ruby 2.7.7p221 (2022-11-24 revision 168ec2b1e5) [aarch64-linux-musl]

Expected Behavior

A dev is able to successfully build and spin up Hyku, with Ruby version 3.2+

image

image

Notes

TODO:

Build a new base image after merger

@ShanaLMoore ShanaLMoore added the minor-ver for release notes label Jul 18, 2024
@ShanaLMoore ShanaLMoore marked this pull request as draft July 18, 2024 23:56
Copy link

Test Results

    3 files  ±0      3 suites  ±0   19m 4s ⏱️ + 1m 15s
2 027 tests ±0  1 968 ✅  - 9  50 💤 ±0  9 ❌ +9 
2 054 runs  ±0  1 993 ✅  - 9  52 💤 ±0  9 ❌ +9 

For more details on these failures, see this check.

Results for commit 4094d05. ± Comparison against base commit 20b8c56.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 5f7f39b8-23e8-4e39-b625-da8deaf04bae
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 6ec32465-aa76-4904-ae3a-b6cff5486b2c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 1c2365ac-bf05-4111-abc2-d924af5088ab
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 4e4adc04-2282-46a2-b0ef-b154799a9697
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 263cebff-09af-43ee-8b47-aa49b8111aa4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4094e82b-739c-4775-92a4-887f6afe3968
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 4c8f5e22-1a14-4cbd-bc9e-5fa78a11cea1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 657cf828-36a8-4dbd-88f0-06c47ed5b7b5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 9cc76d03-c6df-4517-a94d-36d17d6b6c1f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit c48e010c-e973-44cd-812a-f99a23d88643
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b4a9cf66-1ede-4f18-ae31-fd41f5c50acf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 67278705-4309-4e43-8c3e-827a17dac60d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read affb8d25-d309-4d21-bd95-a3e2d6fd439d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 3b065972-86ec-4bea-ba5d-8ba9e3c27de7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 01271592-365e-4b2d-8121-6ffc2a8a2a8b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit c877972f-889c-43ef-888d-4c8f365c6608
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 3e5a80f8-b567-4bfb-a591-e9edac533a40
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 8c4e5e24-b221-4566-9ba4-cb326c740b3c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 7394ac17-bdff-4664-b269-7419eaf67eb7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 386009ba-ab7b-4eb4-aa09-9205b1557da0
…

@ShanaLMoore ShanaLMoore closed this Aug 9, 2024
@orangewolf orangewolf deleted the update-base-image branch August 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant