Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet fixes for catalog search into viewer #2373

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Oct 30, 2024

Summary:

Fix generated work url.
Adjust char limit to accomplish full text search.
Modify view to only load field_value once.
Adjust specs for url change.

refs scientist-softserv/adventist_knapsack#769

Screenshots

Snippets are found and highlighted in catalog search

Screenshot 2024-10-30 at 4 51 25 PM

Metadata searches are found in catalog search and do not show snippets

Screenshot 2024-10-30 at 4 51 38 PM

Catalog search carries into universal viewer

Screenshot 2024-10-30 at 4 52 39 PM

Remaining known issues

  • There seems to be come caching of a search which can carry along into the viewer occasionally
  • Snippets issues scientist-softserv/adventist_knapsack#863 The annotations counts and markings on the viewer are incorrect... counts are doubled, and an extra annotation also exists with no location.
  • When a query carries into the viewer, it doesn't open the page where the first hit is located. This is likely due to one of the extra annotations that has no location (so it's positioned at the beginning of the document)

Fix generated work url.
Adjust char limit to accomplish full text search.
Modify view to only load field_value once.
Adjust specs for url change.
@laritakr laritakr added minor-ver for release notes patch-ver for release notes and removed minor-ver for release notes labels Oct 30, 2024
Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 48s ⏱️ -2s
2 040 tests ±0  1 990 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 067 runs  ±0  2 015 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit 2d74b8c. ± Comparison against base commit 6b9b19f.

This pull request removes 43 and adds 43 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a109ff7d-2002-4548-b417-ffffc5b9a13d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 311a66c5-6af5-417e-b572-51ffba008a28
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read a2bfa384-72b1-405e-a02b-9a4ca569e536
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 72c1ffd9-1ba6-4ee8-951b-870137d60717
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 6ed9a1cc-33c1-408e-a128-8973b39dc0f8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit c1c3d1de-5393-44d6-870c-43ffefed8df9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 50970492-b279-413a-b61a-fa413c9d9274
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 369a2045-b9d0-4214-8ede-1201e0891f60
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 8e147a3c-60aa-4d7f-bed3-03ba33cd1086
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5d3b54a5-cf41-4c1a-b2ed-ace1b180c909
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 3d866a8c-5c35-45e2-962a-891fc8e4db3e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 8290c1da-3095-444f-854a-d9e86120b59b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 04e0118c-906c-4ce7-aa8f-f13cff3aeac9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update eacb8348-b830-4d6a-8fdb-c9075a31d4f2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 020b233d-c9ba-4e07-9ed1-2087cd9c088c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 9e74aba1-ab48-40e3-9381-402c20a95d4c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 4dde9528-bf2b-44c8-98c5-81b189d35085
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update ed317fe9-0cbd-4dbf-8fd8-6b70e04eae3d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 7849075e-7241-469d-9e7a-247126b670a8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1819bfa9-eb55-4dd3-b6ac-a36db8aa61ee
…

@ShanaLMoore ShanaLMoore merged commit fdbf4af into main Oct 30, 2024
8 checks passed
@ShanaLMoore ShanaLMoore deleted the snippets-fix-catalog-query branch October 30, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants