Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Add default for simple form wrappers inline #2422

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

kirkkwang
Copy link
Collaborator

@kirkkwang kirkkwang commented Jan 21, 2025

Story

This commit will adjust the wrappers (inline) default styling to make the elements look like they're not squished. Which was particularly affecting the lease forms.

Issue

Before:

image image

After:

image image

This commit will adjust the wrappers (inline) default styling to make
the elements look like they're not squished.  Which was particularly
affecting the lease forms.
@kirkkwang kirkkwang force-pushed the set-defaults-for-wrappers-inline branch from 3d2ef0b to 9bea382 Compare January 21, 2025 16:31
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 21, 2025
Copy link
Collaborator

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! I've never seen this config before 👀 How did you discover it? It looks so much better

@kirkkwang
Copy link
Collaborator Author

@ShanaLMoore Thanks! When I was working with Sarah, one of her tickets required a change in a similar config. For this one I tracked down what Hyrax used and was able to adjust accordingly.

Copy link

github-actions bot commented Jan 21, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 27s ⏱️ -24s
2 055 tests ±0  1 999 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 082 runs  ±0  2 024 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 9bea382. ± Comparison against base commit 3a1d3ec.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 9dc16e1f-0723-45aa-ad25-2a063fa77a82
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 0c57a33e-7eb3-4be3-b233-83516e34f4db
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 2a32eec8-b17b-4ed6-a64f-a1857e0d2cd4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 5d8668e1-8dd0-4c0b-bd51-64b6172fc0e1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 79a5f055-6f15-44ee-a8d5-37e2cc2df706
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4f5fcd48-ebf7-4f39-88aa-c165249aae61
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read b07ec842-bac6-4325-bac6-3621d252f05b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 09349680-c39c-4190-abdc-fb208beba2d1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy c836b9ab-390d-4f5f-a642-1e274ff0e468
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 746204df-05db-449d-b00c-0591a011bf44
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 5e99861a-0d36-422d-b230-f1bad407febd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 344dd3d5-2d14-4595-8a4b-1bf433aba783
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ca6aa202-52f7-43f1-bd00-161efdcf7154
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update ea0107c9-5343-4d1a-8c2e-181eaeaff498
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy ca2ec6a7-871b-4656-b98a-3eed8b4db1fb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 1d9f5fe0-56ee-4616-8cc6-2c956c1ec233
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 5a669726-7fc0-4ee4-993c-3b940180775b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 69ac5abe-0db2-4fac-ba02-18b227149ee9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 3febdb24-b7bf-4745-ab01-a7ffd4614fb1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1308fd62-ef1e-4a7e-80d9-5128d781d4c6
…

♻️ This comment has been updated with latest results.

@kirkkwang kirkkwang merged commit 6939a58 into main Jan 21, 2025
9 checks passed
@kirkkwang kirkkwang deleted the set-defaults-for-wrappers-inline branch January 21, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants