Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Clean up featured collection UI #2430

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

kirkkwang
Copy link
Collaborator

@kirkkwang kirkkwang commented Jan 24, 2025

This commit will add a few more html tags to the featured collections, both from the admin end and public facing end, to make it look more like the featured works. This will fix custom font issues where the titles of the collections were not getting the correct font that was set.

Admin view:

image

Public view:

image

Ref:

This commit will add a few more html tags to the featured collections,
both from the admin end and public facing end, to make it look more like
the featured works.  This will fix custom font issues where the titles
of the collections were not getting the correct font that was set.
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 24, 2025
Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 59s ⏱️ +30s
2 056 tests ±0  2 000 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 083 runs  ±0  2 025 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit f31c42e. ± Comparison against base commit c90b207.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy bf8f19e5-09fc-4b76-b127-7ff731443ae6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 6dfcf8c4-1f30-4a34-9b21-6b363703ede5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f01c1088-5394-404c-b97c-6162146aaf52
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 2fe747ea-27d0-466d-93c0-323e22a98f7a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3142e524-fafe-40e8-890a-c7ef5a477037
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 926f5adf-b7ba-4118-8b22-345d81c5039d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read b7fc0454-06c6-4e0c-a682-993a895434ae
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 916607ab-d7e0-4ddb-8a65-008bf4bf514e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy fdcc7519-3ff0-4fbe-952c-de94b25f2f96
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit cd25be5b-3d70-44ed-a0f9-cbb615c96fe8
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a20ca84a-b235-4a49-843c-5f6220b55025
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 9f12347d-882f-4c8c-ade3-a314cd3073cd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 09e405e0-962a-4cb4-aac7-fe5ceafd9a51
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 59db8ba4-8ba1-48e0-930c-9ee0d567df1c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 0937c64b-810a-4669-9287-232edb5add73
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit d69b774c-86e0-41b8-a955-c9eb5ad6507f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 4de497e4-6a94-41df-bdb7-92514cc7d5b8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update ac6fd7b3-f993-4bf1-b98b-8c3f8ad787bb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 604d5527-148c-4ee1-90a1-2635adc7b280
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit d863c154-dec6-4852-9579-b44a9df19e1b
…

Copy link
Collaborator

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add issue numbers to your PRs so that github can link them? It'll make things much easier to track for our future selves. Besides that it looks good to me.

@kirkkwang
Copy link
Collaborator Author

Could you add issue numbers to your PRs so that github can link them? It'll make things much easier to track for our future selves. Besides that it looks good to me.

Sounds good!

@kirkkwang kirkkwang requested a review from ShanaLMoore January 24, 2025 21:43
@kirkkwang kirkkwang merged commit 9f98d14 into main Jan 24, 2025
9 checks passed
@kirkkwang kirkkwang deleted the clean-up-featured-collections-ui branch January 24, 2025 21:59
kirkkwang added a commit to notch8/palni_palci_knapsack that referenced this pull request Jan 24, 2025
Update submodule to bring in font fixes.

Ref:
  - samvera/hyku#2430
  - #178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants