-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Clean up featured collection UI #2430
Conversation
This commit will add a few more html tags to the featured collections, both from the admin end and public facing end, to make it look more like the featured works. This will fix custom font issues where the titles of the collections were not getting the correct font that was set.
Test Results 3 files ±0 3 suites ±0 17m 59s ⏱️ +30s Results for commit f31c42e. ± Comparison against base commit c90b207. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add issue numbers to your PRs so that github can link them? It'll make things much easier to track for our future selves. Besides that it looks good to me.
Sounds good! |
Update submodule to bring in font fixes. Ref: - samvera/hyku#2430 - #178
This commit will add a few more html tags to the featured collections, both from the admin end and public facing end, to make it look more like the featured works. This will fix custom font issues where the titles of the collections were not getting the correct font that was set.
Admin view:
Public view:
Ref: