Issue 6783 #6964
Open
Issue 6783 #6964
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6783
Summary
Adds labels and aria-labelledby attribute to checkbox lists on Expired Active Embargoes
Type of change (for release notes)
notes-minorNew Features that are backward compatibleDetailed Description
Adds label around titles in checkbox list (or around question text or "Select All" text) and adds aria-labelledby attribute on checkbox inputs using checkbox input id. The batch_select/_add_button seems to be a reusable bit of code but from what I can tell the change there should work in other checkbox lists that might use it.
@samvera/hyrax-code-reviewers